78120[FEATURE] Introduce php-intl based date&time formatting
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Localization/DateFormatter.phpnew+61 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100187-ICU-basedDateAndTimeFormatting.rst3new+97 −0
- typo3/sysext/core/Tests/Unit/Localization/DateFormatterTest.phpnew+132 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/DateViewHelper.php7+56 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/DateViewHelperTest.php+30 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php3+30 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+87 −2
Review log 2433
Show 58 earlier messages
-
Benni Mack uploaded patch set 1 03/14/23, 14:07
-
core-ci voted on patch set 1 V -1 03/14/23, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38928
-
Benni Mack uploaded patch set 2
V -103/16/23, 20:22 -
core-ci voted on patch set 2 V +1 03/16/23, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39069
-
Benni Mack uploaded patch set 3
V +103/16/23, 21:40 -
Benni Mack uploaded patch set 4 03/16/23, 21:42
-
Benni Mack updated the commit message in patch set 5 03/16/23, 21:47
-
core-ci voted on patch set 4 V -1 03/16/23, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39074
-
core-ci voted on patch set 5 V -1 03/16/23, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39075
-
core-ci voted on patch set 3 V -1 03/16/23, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39073
-
Benni Mack uploaded patch set 6
V -103/16/23, 22:07 -
core-ci voted on patch set 6 V +1 03/16/23, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39077
-
Georg Ringer commented on patch set 6 03/17/23, 07:16
ContentObjectRenderer.php:1924this could be false. should be check that below? -
Stefan Bürk commented on patch set 6 03/17/23, 07:17
DateViewHelper.php:105Should we not add the new arguments as description here - I guess this is used for ViewHelper api rendering or something like that.DateViewHelper.php:127Should we somehow emphasize that if `pattern` and `format` are both given, `pattern`has the higher order and is taken over the old format argument ?DateViewHelper.php:194Introducing new global variable access here ? At least, we should hand over the `$renderingContext` and look if the request is set there - and doing this as fallback here. Or can we avoid the fallback at all somehow and avoid introducing new global variable usage ? -
Benni Mack commented on patch set 6 03/17/23, 08:54
Feature-100187-ICU-basedDateAndTimeFormatting.rst:22ReplyThat's a separate issue which I want to address separately (= this won't be an issue anymore with my next patch)DateViewHelper.php:194Replygood point, thank youContentObjectRenderer.php:1924Replygood point, will fix -
Benni Mack uploaded patch set 7
V +103/17/23, 09:22 -
Benni Mack commented on patch set 7 03/17/23, 09:23
Feature-100187-ICU-basedDateAndTimeFormatting.rst:22ReplyDoneDateViewHelper.php:127ReplyDoneDateViewHelper.php:194ReplyDoneContentObjectRenderer.php:1924ReplyDone -
core-ci voted on patch set 7 V +1 03/17/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39109
-
Georg Ringer voted on patch set 7 V +1 CR +1 03/17/23, 09:38
-
Oli Bartsch commented on patch set 7 CR -1 03/17/23, 11:18
reviewing -
Oli Bartsch uploaded patch set 8
CR +1V +103/17/23, 11:54 -
Oli Bartsch voted on patch set 8 V +1 CR +1 03/17/23, 11:56
-
Oli Bartsch commented on patch set 8 03/17/23, 11:56
DateViewHelper.php:105ReplyDone -
Georg Ringer voted on patch set 8 V +1 CR +1 03/17/23, 11:57
-
core-ci voted on patch set 8 V +1 03/17/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39119
-
Stefan Bürk voted on patch set 8 V +1 CR +1 03/17/23, 12:03
-
Stefan Bürk voted on patch set 8 CR -1 03/17/23, 12:03
-
Stefan Bürk commented on patch set 9
CR +1V +103/17/23, 12:04Published edit on patch set 8. -
Stefan Bürk voted on patch set 9 V +1 CR +1 03/17/23, 12:04
-
core-ci voted on patch set 9 V +1 03/17/23, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39120
-
Oli Bartsch voted on patch set 9 V +1 CR +1 03/17/23, 14:08
-
Benni Mack voted on patch set 9 V +2 CR +2 03/17/23, 14:18
-
Benni Mack merged patch set 10 03/17/23, 14:18
Feature-100187-ICU-basedDateAndTimeFormatting.rst:22