Review 11.5 Merged

78122[TASK] Streamline logging in method TSFE->set_no_cache

Christian Kuhn CR +2 V +2 Easy +5 −9 updated 03/14/23, 14:52

Commit message

The logging in the method set_no_cache should not depend on the calling
parameter $internal. Instead it should be notice in both cases.
Since it's possible to change the general log level during development
or debugging the entries will still be visible, just not on production
systems which makes good sense.
In addition the variable $internal was renamed to $internalRequest in order to make the purpose clearer.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 03/14/23, 14:17

  2. Oliver Klee voted on patch set 1 CR +1 03/14/23, 14:26

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/14/23, 14:43

  4. Christian Kuhn merged patch set 2 03/14/23, 14:43

  5. core-ci voted on patch set 1 V +1 03/14/23, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38931