Review main Merged

78125[BUGFIX] TS parser: Avoid warning on invalid directories

Christian Kuhn CR +2 V +2 Easy +17 −2 updated 03/14/23, 16:18

Commit message

Having an invalid wildcard import to a not existing directory
should not raise a "No such file or directory" PHP warning:

@import 'EXT:sitepackage/.../NonExistingFolder/*.tsconfig'

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/14/23, 16:03

  2. core-ci voted on patch set 1 V +1 03/14/23, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38937

  3. Oliver Klee voted on patch set 1 V +1 CR +1 03/14/23, 16:13

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/14/23, 16:15

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/14/23, 16:18

  6. Christian Kuhn merged patch set 2 03/14/23, 16:18