78132[BUGFIX] Only set Content-Type charset for text/html or JSON
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
- Helmut Hummel +1
-
Verified V +2 Done
- Georg Ringer +2
- Helmut Hummel +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1113
-
Benni Mack uploaded patch set 1 03/15/23, 16:17
-
core-ci voted on patch set 1 V +1 03/15/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38995
-
Oliver Klee commented on patch set 1 03/15/23, 16:34
ticket ID missing -
Benni Mack marked it work in progress 03/15/23, 17:02
-
Achim Fritz commented on patch set 1 03/16/23, 08:31
Bootstrap.php:170i think setting TSFE contentType is still required, because applyHttpHeadersToResponse() override always the contentTypeTypoScriptFrontendController.php:472sould be 'text/html; charset=utf-8'TypoScriptFrontendController.php:2334hm, this is for compatibility? (i would be prefer to not modify the contentType her) -
Benni Mack uploaded patch set 2
V +103/16/23, 22:27 -
Benni Mack marked it ready for review 03/16/23, 22:27
-
Benni Mack commented on patch set 2 03/16/23, 22:28
Reply
DoneBootstrap.php:170Replydone already a few lines above now.TypoScriptFrontendController.php:472Replythanks, fixed.TypoScriptFrontendController.php:2334Replyyes. removed. -
core-ci voted on patch set 2 V +1 03/16/23, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39082
-
Markus Klein voted on patch set 2 CR +1 03/17/23, 07:33
-
Helmut Hummel commented on patch set 2 V +1 CR +1 03/18/23, 14:51
Ah. Didn't consider that case. The fix like suggested here makes sense. Thanks! -
Georg Ringer voted on patch set 2 V +2 CR +2 03/19/23, 14:19
-
Georg Ringer merged patch set 3 03/19/23, 14:19