Review main Merged

78132[BUGFIX] Only set Content-Type charset for text/html or JSON

Benni Mack CR +2 V +2 Easy +3 −5 updated 03/19/23, 14:19

Commit message

When using TYPO3 as a response for multipart
result or application/binary responses,
TSFE should not append "charset=utf-8" to the
Content-Type HTTP response header.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1113

  1. Benni Mack uploaded patch set 1 03/15/23, 16:17

  2. core-ci voted on patch set 1 V +1 03/15/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38995

  3. Oliver Klee commented on patch set 1 03/15/23, 16:34

    ticket ID missing
  4. Benni Mack marked it work in progress 03/15/23, 17:02

  5. Achim Fritz commented on patch set 1 03/16/23, 08:31

    Bootstrap.php:170

    i think setting TSFE contentType is still required, because applyHttpHeadersToResponse() override always the contentType

    TypoScriptFrontendController.php:472

    sould be 'text/html; charset=utf-8'

    TypoScriptFrontendController.php:2334

    hm, this is for compatibility? (i would be prefer to not modify the contentType her)
  6. Benni Mack uploaded patch set 2 V +1 03/16/23, 22:27

  7. Benni Mack marked it ready for review 03/16/23, 22:27

  8. Benni Mack commented on patch set 2 03/16/23, 22:28

    Reply

    Done

    Bootstrap.php:170 Reply

    done already a few lines above now.

    TypoScriptFrontendController.php:472 Reply

    thanks, fixed.

    TypoScriptFrontendController.php:2334 Reply

    yes. removed.
  9. core-ci voted on patch set 2 V +1 03/16/23, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39082

  10. Markus Klein voted on patch set 2 CR +1 03/17/23, 07:33

  11. Helmut Hummel commented on patch set 2 V +1 CR +1 03/18/23, 14:51

    Ah. Didn't consider that case. The fix like suggested here makes sense. Thanks!
  12. Georg Ringer voted on patch set 2 V +2 CR +2 03/19/23, 14:19

  13. Georg Ringer merged patch set 3 03/19/23, 14:19