78134[TASK] Change wording of "PageTsConfig Records"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+1 −1
- typo3/sysext/backend/Configuration/Backend/Modules.php2+1 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_pagetsconfig.xlf+10 −11
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/RecordsOverview.html+5 −5
Review log 1518
-
Georg Ringer uploaded patch set 1 03/15/23, 21:10
-
Georg Ringer commented on patch set 1 03/15/23, 21:10
This change is ready for review. -
core-ci voted on patch set 1 V +1 03/15/23, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39014
-
Jasmina Ließmann commented on patch set 1 03/16/23, 08:26
Since this view shows pages that contain page TSconfig, I would suggest naming it "Pages containing PageTsConfig" instead of "PageTsConfig List". The language variable could be "pagetsconfig_pages". What do you think? -
Georg Ringer commented on patch set 1 03/16/23, 08:45
Reply
yes makes sense. do you wanna make the change? -
Jasmina Ließmann uploaded patch set 2
V +103/16/23, 09:21 -
Jasmina Ließmann commented on patch set 2 03/16/23, 09:22
Reply
Done -
Georg Ringer voted on patch set 2 V +1 CR +1 03/16/23, 09:24
-
core-ci voted on patch set 2 V +1 03/16/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39046
-
Josef Glatz voted on patch set 2 V +1 CR +1 03/16/23, 09:33
-
Guido Schmechel voted on patch set 2 V +1 CR +1 03/19/23, 15:21
-
Christian Kuhn uploaded patch set 3
CR +1V +103/27/23, 07:15 -
Christian Kuhn voted on patch set 3 V +1 CR +1 03/27/23, 07:20
-
core-ci voted on patch set 3 V +1 03/27/23, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39665
-
Benni Mack voted on patch set 3 V +1 CR +1 03/27/23, 07:52
-
Benni Mack commented on patch set 3 03/27/23, 07:52
Modules.php:101we could even adapt the module identifier and the paht property below -
Christian Kuhn commented on patch set 3 V +2 CR +2 03/27/23, 09:31
Modules.php:101Replyyeah. will adapt with a different patch, the rows are links to nothing, will adapt. -
Christian Kuhn merged patch set 4 03/27/23, 09:33