Review main Merged

78134[TASK] Change wording of "PageTsConfig Records"

Georg Ringer CR +2 V +2 Easy +17 −18 updated 03/27/23, 09:33

Commit message

As there are no records regarding PageTsConfig,
the wording should be adopted.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1518

  1. Georg Ringer uploaded patch set 1 03/15/23, 21:10

  2. Georg Ringer commented on patch set 1 03/15/23, 21:10

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/15/23, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39014

  4. Jasmina Ließmann commented on patch set 1 03/16/23, 08:26

    Since this view shows pages that contain page TSconfig, I would suggest naming it "Pages containing PageTsConfig" instead of "PageTsConfig List". The language variable could be "pagetsconfig_pages". What do you think?
  5. Georg Ringer commented on patch set 1 03/16/23, 08:45

    Reply

    yes makes sense. do you wanna make the change?
  6. Jasmina Ließmann uploaded patch set 2 V +1 03/16/23, 09:21

  7. Jasmina Ließmann commented on patch set 2 03/16/23, 09:22

    Reply

    Done
  8. Georg Ringer voted on patch set 2 V +1 CR +1 03/16/23, 09:24

  9. core-ci voted on patch set 2 V +1 03/16/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39046

  10. Josef Glatz voted on patch set 2 V +1 CR +1 03/16/23, 09:33

  11. Guido Schmechel voted on patch set 2 V +1 CR +1 03/19/23, 15:21

  12. Christian Kuhn uploaded patch set 3 CR +1 V +1 03/27/23, 07:15

  13. Christian Kuhn voted on patch set 3 V +1 CR +1 03/27/23, 07:20

  14. core-ci voted on patch set 3 V +1 03/27/23, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39665

  15. Benni Mack voted on patch set 3 V +1 CR +1 03/27/23, 07:52

  16. Benni Mack commented on patch set 3 03/27/23, 07:52

    Modules.php:101

    we could even adapt the module identifier and the paht property below
  17. Christian Kuhn commented on patch set 3 V +2 CR +2 03/27/23, 09:31

    Modules.php:101 Reply

    yeah. will adapt with a different patch, the rows are links to nothing, will adapt.
  18. Christian Kuhn merged patch set 4 03/27/23, 09:33