Review 11.5 Merged

78139[BUGFIX] Backport null checks to Core QueryGenerator

JAKOTA Design Group GmbH CR +2 V +2 Hard +126 −127 updated 04/11/23, 11:42

Commit message

This file was removed in v12 and only the version in
TYPO3\CMS\Lowlevel\Database\QueryGenerator
was updated with fixes.

This patch backports all the checks to the v11
TYPO3\CMS\Core\Database\QueryGenerator

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Ralph Brugger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. JAKOTA Design Group GmbH uploaded patch set 1 03/16/23, 19:44

  2. core-ci voted on patch set 1 V -1 03/16/23, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39067

  3. JAKOTA Design Group GmbH uploaded patch set 2 V -1 03/16/23, 20:34

  4. core-ci voted on patch set 2 V +1 03/16/23, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39070

  5. JAKOTA Design Group GmbH uploaded patch set 3 V +1 03/16/23, 21:07

  6. core-ci voted on patch set 3 V +1 03/16/23, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39072

  7. Ralph Brugger commented on patch set 3 CR +1 03/17/23, 07:49

    Looks good in our Environment. direct_mail seems to be happy.
  8. Oliver Klee voted on patch set 3 CR +1 03/17/23, 09:01

  9. JAKOTA Design Group GmbH commented on patch set 3 03/31/23, 09:14

    Hi, any news here on how to proceed?
  10. Christian Kuhn voted on patch set 3 V +1 CR +1 04/11/23, 11:21

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 04/11/23, 11:42

  12. Andreas Kienast merged patch set 4 04/11/23, 11:42