Review main Merged

78140[BUGFIX] Prevent endless loop in PageLinkBuilder

Christoph Lehmann CR +2 V +2 Easy +7 −1 updated 03/18/23, 10:35

Commit message

By re-using an already resolved page #99612 introduced an endless loop
during HMENU/Sitemap rendering: An external page (doktype=3) with a
simple query string like '?showModal=1' resolves to itself over and over
where the current page is the correct target.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Christoph Lehmann uploaded patch set 1 03/16/23, 21:59

  2. core-ci voted on patch set 1 V +1 03/16/23, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39076

  3. Christoph Lehmann uploaded patch set 2 V +1 03/16/23, 22:10

  4. Christoph Lehmann updated the commit message in patch set 3 03/16/23, 22:11

  5. Christoph Lehmann updated the commit message in patch set 4 03/16/23, 22:11

  6. core-ci voted on patch set 2 V +1 03/16/23, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39078

  7. Benni Mack voted on patch set 4 CR +1 03/16/23, 22:22

  8. core-ci voted on patch set 3 V +1 03/16/23, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39079

  9. core-ci voted on patch set 4 V +1 03/16/23, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39080

  10. Benni Mack voted on patch set 4 V +1 03/16/23, 22:51

  11. Stefan Bürk voted on patch set 4 CR +1 03/18/23, 10:22

  12. Stefan Bürk voted on patch set 4 V +2 CR +2 03/18/23, 10:35

  13. Stefan Bürk merged patch set 5 03/18/23, 10:35