Review main Merged

7816[BUGFIX] TypoLink: absolute urls when installed in subfolder

Susi Moog CR +2 V +2 Easy +10 −1 updated 06/03/13, 20:49

Commit message

If you have TYPO3 installed in a subfolder and a domain
record with that subfolder (localhost/subfolder/ for
example) TYPO3 only generates absolute links in the
frontend.

This is because the typoLink function compares the
HTTP_HOST var with the domainRecord. HTTP_HOST is in
this case "localhost", the domain record has the subfolder
attached. The subfolder needs to be there, as otherwise
t3lib_pageSelect::getDomainStartPage does not find the
start page anymore. typoLink should check for HTTP_HOST +
path of SCRIPT_NAME to determine which domain record
to use (same as getDomainStartPage already does).

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Philipp Gampe +1

Files 1

Review log 13

  1. Tolleiv Nietsch commented on patch set 1 V 0 02/17/12, 14:22

    by team member; Looks good to me, approved wow, just realized that I never installed typo3 in a subfolder before
  2. Markus Klein commented on patch set 1 02/17/12, 14:22

    I would prefer that you didn't submit this
    Fixes
  3. Markus Klein commented on patch set 1 02/17/12, 14:22

    http://wiki.typo3.org/CommitMessage_Format_%28Git%29 This has been different a long time ago, but has been changed. BUGFIX => Fixes others => Resolves Sorry for nitpicking, but this is the first point where consequence starts.
  4. Susi Moog commented on patch set 1 V 0 02/17/12, 14:22

    by team member; Looks good to me, approved
  5. Susi Moog commented on patch set 1 02/17/12, 14:22

    @Markus: Resolves and Fixes both work and are both ok, afaik. Where did you find the info that only "fixes" is allowed? Please point me to a link (and have a look at other patch sets, both fixes and resolves are used quite often...)
  6. Philipp Gampe commented on patch set 1 02/17/12, 14:22

    Verified; Looks good to me, but someone else must approve I changed the commit message. I could not reproduce this bug?! see forge.
  7. Philipp Gampe commented on patch set 1 02/17/12, 14:22

    I should have pushed ;)
  8. Tolleiv Nietsch commented on patch set 2 V 0 02/17/12, 14:22

    by team member; Looks good to me, approved
  9. Philipp Gampe commented on patch set 2 02/17/12, 14:22

    Verified; Looks good to me, but someone else must approve Gerrit hickups today? I *did* vote.
  10. Philipp Gampe uploaded patch set 2 02/17/12, 14:22

  11. Mr. Jenkins commented on patch set 1 02/17/12, 14:22

  12. Mr. Jenkins commented on patch set 2 02/17/12, 14:22

  13. Susi Moog merged patch set 2 02/17/12, 14:22