7816[BUGFIX] TypoLink: absolute urls when installed in subfolder
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Philipp Gampe +1
Files 1
Review log 13
-
Tolleiv Nietsch commented on patch set 1 V 0 02/17/12, 14:22
by team member; Looks good to me, approved wow, just realized that I never installed typo3 in a subfolder before -
Markus Klein commented on patch set 1 02/17/12, 14:22
I would prefer that you didn't submit thisFixes -
Markus Klein commented on patch set 1 02/17/12, 14:22
http://wiki.typo3.org/CommitMessage_Format_%28Git%29 This has been different a long time ago, but has been changed. BUGFIX => Fixes others => Resolves Sorry for nitpicking, but this is the first point where consequence starts. -
Susi Moog commented on patch set 1 V 0 02/17/12, 14:22
by team member; Looks good to me, approved -
Susi Moog commented on patch set 1 02/17/12, 14:22
@Markus: Resolves and Fixes both work and are both ok, afaik. Where did you find the info that only "fixes" is allowed? Please point me to a link (and have a look at other patch sets, both fixes and resolves are used quite often...) -
Philipp Gampe commented on patch set 1 02/17/12, 14:22
Verified; Looks good to me, but someone else must approve I changed the commit message. I could not reproduce this bug?! see forge. -
Philipp Gampe commented on patch set 1 02/17/12, 14:22
I should have pushed ;) -
Tolleiv Nietsch commented on patch set 2 V 0 02/17/12, 14:22
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 2 02/17/12, 14:22
Verified; Looks good to me, but someone else must approve Gerrit hickups today? I *did* vote. -
Philipp Gampe uploaded patch set 2 02/17/12, 14:22
-
Mr. Jenkins commented on patch set 1 02/17/12, 14:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2975/ : SUCCESS -
Mr. Jenkins commented on patch set 2 02/17/12, 14:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3189/ : SUCCESS -
Susi Moog merged patch set 2 02/17/12, 14:22