Review main Merged

78161[TASK] Use userland strftime() implementation for deprecated PHP function

Benni Mack CR +2 V +2 Hard +234 −17 updated 03/20/23, 15:23

Commit message

This change finally removes all usages to strftime(),
as this function was deprecated in PHP 8.1.
It is recommended to use php-intl to use locale-aware
date formatting.

For places, where no alternative is available
(stdWrap and <f:format.date>),
a polyfill function, which credits to
https://github.com/alphp/strftime
is added to the DateFormatter class.

Kudos to the original autor "BohwaZ" (https://bohwaz.net/)
and the GitHub Repository for allowing us
to use this (MIT license). Open Source rocks!

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1117

  1. Benni Mack uploaded patch set 1 03/17/23, 20:47

  2. Benni Mack uploaded patch set 2 03/17/23, 20:48

  3. core-ci voted on patch set 2 V -1 03/17/23, 21:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39158

  4. core-ci voted on patch set 1 V -1 03/17/23, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39157

  5. Benni Mack uploaded patch set 3 V -1 03/17/23, 22:21

  6. Benni Mack rebased onto patch set 4 03/17/23, 23:25

  7. core-ci voted on patch set 3 V -1 03/17/23, 23:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39167

  8. core-ci voted on patch set 4 V -1 03/17/23, 23:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39169

  9. Stefan Bürk commented on patch set 4 CR -1 03/18/23, 12:04

    on it ...
  10. Stefan Bürk uploaded patch set 5 CR -1 V -1 03/18/23, 12:19

  11. Stefan Bürk uploaded patch set 6 03/18/23, 12:22

  12. core-ci voted on patch set 6 V +1 03/18/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39185

  13. core-ci voted on patch set 5 V +1 03/18/23, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39184

  14. Stefan Bürk voted on patch set 6 V +1 CR +1 03/18/23, 16:22

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 03/20/23, 14:15

  16. Benni Mack voted on patch set 6 V +2 CR +2 03/20/23, 15:23

  17. Benni Mack merged patch set 7 03/20/23, 15:23