Review main Merged

78162[TASK] Use BackedEnum for LikeWildcard

Benni Mack CR +2 V +2 Easy +17 −24 updated 03/18/23, 11:39

Commit message

PHP 8 introduced native Enumerations,
which can now be used instead of our own
implementation from TYPO3 v7.

Enums are effectively singletons making
it much faster than previously when
used many times.

Since LikeWildcard in indexed search is
internal and only used internally within
indexed search, the usage is rather small.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 03/17/23, 21:47

  2. core-ci voted on patch set 1 V -1 03/17/23, 22:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39162

  3. Benni Mack uploaded patch set 2 V -1 03/17/23, 22:23

  4. core-ci voted on patch set 2 V +1 03/17/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39168

  5. Stefan Bürk commented on patch set 3 V +1 03/18/23, 09:03

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 03/18/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39181

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 03/18/23, 09:14

  8. Georg Ringer voted on patch set 3 V +2 CR +2 03/18/23, 11:39

  9. Georg Ringer merged patch set 4 03/18/23, 11:39