Review 11.5 Merged

78168[BUGFIX] Respect nullable date time fields

JAKOTA Design Group GmbH CR +2 V +2 Normal +148 −16 updated 07/06/23, 07:10

Commit message

Nullable time fields with value null (not set) are reset to 0 on update.
This changes the value from not set to midnight.

It is not so problematic for date fields as there reset value,
for the time being, is null also. But this behavior is wrong anyway.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1321

  1. JAKOTA Design Group GmbH uploaded patch set 1 03/18/23, 13:12

  2. core-ci voted on patch set 1 V +1 03/18/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39186

  3. Benni Mack updated the commit message in patch set 2 V +1 05/03/23, 09:37

  4. Markus Klein uploaded patch set 3 07/05/23, 19:17

  5. Markus Klein commented on patch set 4 07/05/23, 19:18

    Published edit on patch set 3.
  6. JAKOTA Design Group GmbH commented on patch set 3 07/05/23, 19:23

    DatabaseRowDateTimeFields.php:49

    If I'm not mistaken the nullable key was added in 12.x. That's why I added a patch for 11.5 where you have to go this way. GeneralUtility::inList($columnConfig['config']['eval'] ?? '', 'null')
  7. core-ci voted on patch set 3 V -1 07/05/23, 19:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43602

  8. Markus Klein uploaded patch set 5 07/05/23, 19:48

  9. Markus Klein commented on patch set 5 07/05/23, 19:48

    DatabaseRowDateTimeFields.php:49 Reply

    Thanks, I will adjust this. I actually backported this rather "straight" to see what CI says in general.
  10. core-ci voted on patch set 4 V +1 07/05/23, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43605

  11. core-ci voted on patch set 5 V -1 07/05/23, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43612

  12. Benni Mack commented on patch set 6 V -1 07/05/23, 20:03

    Published edit on patch set 5.
  13. core-ci voted on patch set 6 V -1 07/05/23, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43614

  14. Markus Klein uploaded patch set 7 V -1 07/05/23, 20:29

  15. core-ci voted on patch set 7 V -1 07/05/23, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43620

  16. Benni Mack commented on patch set 8 V -1 07/05/23, 20:47

    Published edit on patch set 7.
  17. core-ci voted on patch set 8 V -1 07/05/23, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43627

  18. JAKOTA Design Group GmbH uploaded patch set 9 V -1 07/05/23, 23:49

  19. core-ci voted on patch set 9 V +1 07/05/23, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43646

  20. Benni Mack voted on patch set 9 V +2 CR +2 07/06/23, 07:10

  21. Benni Mack merged patch set 10 07/06/23, 07:10