Review 11.5 Merged

78171[BUGFIX] Only set Content-Type charset if no charset is given

Benni Mack CR +2 V +2 Easy +5 −3 updated 03/29/23, 07:09

Commit message

When using TYPO3 as a response for multipart
result or application/binary responses,
TSFE should not append "charset=utf-8" to the
Content-Type HTTP response header.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 03/19/23, 21:27

  2. core-ci voted on patch set 1 V +1 03/19/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39208

  3. Benni Mack updated the commit message in patch set 2 V +1 03/19/23, 22:09

  4. core-ci voted on patch set 2 V +1 03/19/23, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39209

  5. Stephan Großberndt commented on patch set 2 03/28/23, 10:32

    Backport is not merged yet.
  6. Benni Mack commented on patch set 2 03/28/23, 10:33

    Yes. waiting for feedback
  7. Achim Fritz voted on patch set 2 V +1 CR +1 03/29/23, 06:43

  8. Benni Mack commented on patch set 2 V +2 CR +2 03/29/23, 07:09

    Reply

    Done
  9. Benni Mack merged patch set 3 03/29/23, 07:09