Review main Merged

78175[TASK] Fetch RTE yaml configuration only once

Christian Eßl CR +2 V +2 Easy +13 −5 updated 04/24/23, 14:53

Commit message

Avoid a lot of superfluous yaml reading and parsing by fetching
the richtext configuration only once per request, saving some time
in FormEngine, when many inline records with richtext editors are
present or when doing mass editing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Eßl uploaded patch set 1 03/20/23, 14:34

  2. core-ci voted on patch set 1 V +1 03/20/23, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39244

  3. Benni Mack commented on patch set 1 03/20/23, 15:21

    Richtext.php:109

    this would still use the same proc (which is dependent on the field) all the time, so this also needs to be considered for the identifier.
  4. Christian Eßl commented on patch set 1 03/20/23, 16:02

    Richtext.php:109 Reply

    Could you elaborate? At this state, the config in 'proc.' is only read from the yaml file should always be the same for $presetName.
  5. Benni Mack commented on patch set 1 CR +1 03/22/23, 21:13

    Richtext.php:109 Reply

    you are correct. Mea culpa!
  6. Andreas Kienast voted on patch set 1 V +1 CR +1 04/24/23, 14:43

  7. Benni Mack voted on patch set 1 V +2 CR +2 04/24/23, 14:53

  8. Benni Mack merged patch set 2 04/24/23, 14:53