78178[!!!][TASK] Convert MfaViewType to backed enum
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodesProvider.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderInterface.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderManifest.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaViewType.php+5 −7
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100224-MfaViewTypeMigratedToBackedEnum.rstnew+62 −0
Review log 3138
Show 1113 earlier messages
-
Thomas Hohn uploaded patch set 1 03/20/23, 15:23
-
core-ci voted on patch set 1 V +1 03/20/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39249
-
Oliver Klee voted on patch set 1 V +1 CR +1 03/20/23, 15:43
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/20/23, 18:09
-
Oli Bartsch commented on patch set 1 03/20/23, 20:07
While the class is declared as @internal, actually the mfa provider extensions (https://github.com/bnf/mfa_webauthn, https://github.com/o-ba/mfa_hotp, https://github.com/derhansen/mfa_yubikey, ...), published together with the MFA implementation are using those constants. I'm therefore not quite sure whether it's worth to convert the class now and forcing all those extensions to be update. -
Thomas Hohn commented on patch set 1 03/20/23, 20:27
Reply
What do you think @benni ? -
Thomas Hohn commented on patch set 1 03/23/23, 04:41
Reply
Will postpone it to V13 then -
Thomas Hohn rebased onto patch set 2
CR +1V +105/08/23, 12:03 -
core-ci voted on patch set 2 V +1 05/08/23, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41662
-
Oliver Klee voted on patch set 2 V +1 CR +1 05/09/23, 06:41
-
Stefan Froemken voted on patch set 2 CR +1 05/10/23, 20:42
-
Jörg Bösche voted on patch set 2 CR +1 05/26/23, 13:20
-
Oli Bartsch commented on patch set 2 07/04/23, 21:22
Since this is main only, lets change the interface to public function handleRequest( ServerRequestInterface $request, MfaProviderPropertyManager $propertyManager, MfaViewType $type ): ResponseInterface; and therefore always use the enum instead of its string value. This makes the patch smaller, brings more flexibility and makes the migration for extensions simpler.
-
Thomas Hohn rebased onto patch set 3
CR +1V +107/05/23, 04:32 -
core-ci voted on patch set 3 V +1 07/05/23, 04:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43451
-
Thomas Hohn uploaded patch set 4
V +107/05/23, 04:48 -
Thomas Hohn commented on patch set 4 07/05/23, 04:50
Reply
Done -
core-ci voted on patch set 4 V +1 07/05/23, 04:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43452
-
Stefan Froemken commented on patch set 4 V +1 CR +1 07/05/23, 06:34
It's OK for me, but why we are not using the Basic Enumeration? In full patch we don't make use of the scalar equivalent, there is no database record or array value which has to match. -
Thomas Hohn commented on patch set 4 07/05/23, 06:48
Reply
You could argue that it would be possible - however I think that decision should be taken from someone from the core-team. -
Oli Bartsch commented on patch set 4 CR -1 07/05/23, 07:19
Breaking rst missingReply
I'm fine with using native enum. This paves the way for further improvements. -
Thomas Hohn commented on patch set 4 07/05/23, 07:20
Reply
Even though the class is internal? -
Oli Bartsch uploaded patch set 5
CR +1V +107/05/23, 07:40 -
Oli Bartsch commented on patch set 5 V +1 CR +1 07/05/23, 07:41
Reply
Actually, it was meant to be internal until v11 release and was never adjusted. Actually the class is required to be used by all custom MFA providers. Otherwise they are not registered. -
core-ci voted on patch set 5 V +1 07/05/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43467
-
Oliver Klee voted on patch set 5 V +1 CR +1 07/05/23, 07:56
-
Andreas Kienast updated the commit message in patch set 6
CR +1V +107/05/23, 08:01 -
core-ci voted on patch set 6 V +1 07/05/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43468
-
Oliver Klee voted on patch set 6 V +1 CR +1 07/05/23, 08:26
-
Andreas Kienast commented on patch set 6 07/05/23, 08:38
This patch is not breaking according to our guidelines, all affected classes are annotated with `@internal`. -
Thomas Hohn commented on patch set 6 07/05/23, 08:41
Reply
Then I suggest a pre-patch: "Actually, it was meant to be internal until v11 release and was never adjusted. Actually the class is required to be used by all custom MFA providers. Otherwise they are not registered." -
Thomas Hohn uploaded patch set 7
CR +1V +107/05/23, 08:56 -
core-ci voted on patch set 7 V +1 07/05/23, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43475
-
Oli Bartsch commented on patch set 7 V +1 CR +1 07/05/23, 09:46
Reply
Ack -
Jochen Roth voted on patch set 7 V +1 CR +1 07/05/23, 09:51
-
Andreas Kienast voted on patch set 7 V +1 CR +1 07/05/23, 09:52
-
Oli Bartsch voted on patch set 7 V +2 CR +2 07/05/23, 09:52
-
Oli Bartsch merged patch set 8 07/05/23, 09:52