Review main Merged

78183[TASK] Improve performance of FileStorageTreeProvider

Christian Eßl CR +2 V +2 Easy +7 −7 updated 03/29/23, 14:34

Commit message

Improve the performance of FileStorageTreeProvider significantly by
avoiding fetching the parent and children folders multiple times.

In tests with ~6000 folders, this roughly halves the number of reading
operations on the filesystem and reduces the time required for rendering
the tree structure from ~9 seconds to ~4.5 seconds.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Christian Eßl uploaded patch set 1 03/20/23, 18:35

  2. core-ci voted on patch set 1 V +1 03/20/23, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39269

  3. Benni Mack voted on patch set 1 CR +1 03/20/23, 20:14

  4. Christian Eßl updated the commit message in patch set 2 CR +1 V +1 03/26/23, 14:50

  5. Christian Eßl updated the commit message in patch set 3 03/26/23, 14:51

  6. core-ci voted on patch set 2 V +1 03/26/23, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39647

  7. core-ci voted on patch set 3 V +1 03/26/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39648

  8. Benni Mack voted on patch set 3 V +1 CR +1 03/29/23, 11:45

  9. Oliver Klee voted on patch set 3 CR +1 03/29/23, 12:33

  10. Andreas Kienast commented on patch set 3 V +2 CR +2 03/29/23, 14:33

    One hard crash due to full swap and RAM and 325501 directories later, I think this patch is stress tested (as well as my SSD 😄).
  11. Andreas Kienast merged patch set 4 03/29/23, 14:34