Review main Merged

78186[TASK] Split ColumnMapFactory off of DataMapFactory

Alexander Schnitzler CR +2 V +2 Expert +724 −676 updated 03/22/23, 10:18

Commit message

This change splits off the creation of column maps in the
DataFactory class into its own ColumnMapFactory class.

Benefits are:
- clear distinction of responsibilities
- better testability
- easier to understand for readers

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1114

  1. Alexander Schnitzler uploaded patch set 1 03/20/23, 19:42

  2. Alexander Schnitzler wrote 03/20/23, 19:42

    Topic set to extbase
  3. core-ci voted on patch set 1 V -1 03/20/23, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39273

  4. Alexander Schnitzler uploaded patch set 2 V -1 03/21/23, 08:14

  5. core-ci voted on patch set 2 V +1 03/21/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39298

  6. Alexander Schnitzler commented on patch set 2 03/21/23, 08:28

    ColumnMapFactory.php:29

    This is obviously not true. Line needs to be removed.
  7. Markus Klein voted on patch set 2 CR +1 03/21/23, 08:29

  8. Oliver Klee commented on patch set 3 CR +1 V +1 03/21/23, 09:24

    Published edit on patch set 2.
  9. Oliver Klee commented on patch set 3 03/21/23, 09:24

    ColumnMapFactory.php:29 Reply

    Done
  10. core-ci voted on patch set 3 V +1 03/21/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39305

  11. Alexander Schnitzler commented on patch set 3 03/21/23, 11:16

    ColumnMapFactory.php:29 Reply

    Thanks! 😊
  12. Markus Klein voted on patch set 3 V +1 CR +1 03/21/23, 15:10

  13. Benni Mack voted on patch set 3 V +2 CR +2 03/22/23, 10:18

  14. Benni Mack merged patch set 4 03/22/23, 10:18