78186[TASK] Split ColumnMapFactory off of DataMapFactory
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php3new+270 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+10 −245
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/ColumnMapFactoryTest.phpnew+425 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+0 −420
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+19 −11
Review log 1114
-
Alexander Schnitzler uploaded patch set 1 03/20/23, 19:42
-
Alexander Schnitzler wrote 03/20/23, 19:42
Topic set to extbase -
core-ci voted on patch set 1 V -1 03/20/23, 19:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39273
-
Alexander Schnitzler uploaded patch set 2
V -103/21/23, 08:14 -
core-ci voted on patch set 2 V +1 03/21/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39298
-
Alexander Schnitzler commented on patch set 2 03/21/23, 08:28
ColumnMapFactory.php:29This is obviously not true. Line needs to be removed. -
Markus Klein voted on patch set 2 CR +1 03/21/23, 08:29
-
Oliver Klee commented on patch set 3
CR +1V +103/21/23, 09:24Published edit on patch set 2. -
Oliver Klee commented on patch set 3 03/21/23, 09:24
ColumnMapFactory.php:29ReplyDone -
core-ci voted on patch set 3 V +1 03/21/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39305
-
Alexander Schnitzler commented on patch set 3 03/21/23, 11:16
ColumnMapFactory.php:29ReplyThanks! 😊 -
Markus Klein voted on patch set 3 V +1 CR +1 03/21/23, 15:10
-
Benni Mack voted on patch set 3 V +2 CR +2 03/22/23, 10:18
-
Benni Mack merged patch set 4 03/22/23, 10:18