78187[TASK] Improve Filelist sorting
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Christian Eßl uploaded patch set 1 03/20/23, 19:45
-
core-ci voted on patch set 1 V +1 03/20/23, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39274
-
Benni Mack commented on patch set 1 03/20/23, 20:12
Maybe we should fix it like proposed here: https://forge.typo3.org/issues/67187 -
Tymoteusz Motylewski commented on patch set 1 03/21/23, 15:31
Reply
that's would be lovely! The previous patch was blocked because TYPO3 was not requiring intl, which is now solved. -
Christian Eßl commented on patch set 1 03/21/23, 15:59
Reply
It's unrelated to the heavy performance penalties with folder/file sorting right now, but if you insist, I can extend the patch later with better language sorting, when I have the time... -
Benni Mack uploaded patch set 2
V +103/21/23, 22:52 -
core-ci voted on patch set 2 V +1 03/21/23, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39355
-
Christian Eßl updated the commit message in patch set 3
V +103/22/23, 06:36 -
core-ci voted on patch set 3 V +1 03/22/23, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39364
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/22/23, 12:07
-
Tymoteusz Motylewski commented on patch set 3 03/22/23, 12:25
Reply
I'm ok with doing it separately. Thanks for the perf improvements! -
Nikita Hovratov voted on patch set 3 V +2 CR +2 03/22/23, 12:31
-
Nikita Hovratov merged patch set 4 03/22/23, 12:32
-
Benni Mack commented on patch set 3 03/22/23, 12:33
Reply
I already included this in the latest PatchSet. -
Tymoteusz Motylewski commented on patch set 4 03/22/23, 21:53
here is a test for this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78219