Review main Merged

78187[TASK] Improve Filelist sorting

Christian Eßl CR +2 V +2 Easy +10 −5 updated 03/22/23, 21:53

Commit message

Speed up the sorting of files and folders significantly
by simply using uksort instead of usort to save many
unnecessary array_search()-calls.

In addition, the php-intl collator is now
used to sort files based on the backend users'
locale.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Christian Eßl uploaded patch set 1 03/20/23, 19:45

  2. core-ci voted on patch set 1 V +1 03/20/23, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39274

  3. Benni Mack commented on patch set 1 03/20/23, 20:12

    Maybe we should fix it like proposed here: https://forge.typo3.org/issues/67187
  4. Tymoteusz Motylewski commented on patch set 1 03/21/23, 15:31

    Reply

    that's would be lovely! The previous patch was blocked because TYPO3 was not requiring intl, which is now solved.
  5. Christian Eßl commented on patch set 1 03/21/23, 15:59

    Reply

    It's unrelated to the heavy performance penalties with folder/file sorting right now, but if you insist, I can extend the patch later with better language sorting, when I have the time...
  6. Benni Mack uploaded patch set 2 V +1 03/21/23, 22:52

  7. core-ci voted on patch set 2 V +1 03/21/23, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39355

  8. Christian Eßl updated the commit message in patch set 3 V +1 03/22/23, 06:36

  9. core-ci voted on patch set 3 V +1 03/22/23, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39364

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 03/22/23, 12:07

  11. Tymoteusz Motylewski commented on patch set 3 03/22/23, 12:25

    Reply

    I'm ok with doing it separately. Thanks for the perf improvements!
  12. Nikita Hovratov voted on patch set 3 V +2 CR +2 03/22/23, 12:31

  13. Nikita Hovratov merged patch set 4 03/22/23, 12:32

  14. Benni Mack commented on patch set 3 03/22/23, 12:33

    Reply

    I already included this in the latest PatchSet.
  15. Tymoteusz Motylewski commented on patch set 4 03/22/23, 21:53