Review main Merged

78189[FEATURE] Load additional CSS files via TYPO3_CONF_VARS

Benni Mack CR +2 V +2 Normal +155 −27 updated 03/21/23, 20:47

Commit message

This change deprecates the global array $TBE_STYLES
and with that the registration of CSS files for backend
styling, which is now handled via
$GLOBALS['TYPO3_CONF_VARS']['BE']['stylesheets']

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 912

  1. Benni Mack uploaded patch set 1 03/20/23, 20:42

  2. Benni Mack updated the commit message in patch set 2 03/20/23, 20:42

  3. core-ci voted on patch set 1 V +1 03/20/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39277

  4. core-ci voted on patch set 2 V +1 03/20/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39278

  5. Georg Ringer commented on patch set 2 03/20/23, 20:53

    Deprecation-100232-TBE_STYLESSkinningFunctionality.rst:14

    :php:`$TBE_STYLES`

    Feature-100232-LoadAdditionalStylesheetsInTYPO3Backend.rst:17

    should we also use :php:`$TBE_STYLES` here?

    Feature-100232-LoadAdditionalStylesheetsInTYPO3Backend.rst:25

    needs improvement
  6. Benni Mack commented on patch set 3 V +1 03/20/23, 21:45

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 03/20/23, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39281

  8. Benni Mack commented on patch set 3 03/21/23, 09:58

    Deprecation-100232-TBE_STYLESSkinningFunctionality.rst:14 Reply

    Done

    Feature-100232-LoadAdditionalStylesheetsInTYPO3Backend.rst:17 Reply

    Done

    Feature-100232-LoadAdditionalStylesheetsInTYPO3Backend.rst:25 Reply

    Done
  9. Torben Hansen voted on patch set 3 V +1 CR +1 03/21/23, 17:23

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 03/21/23, 19:44

  11. Benni Mack voted on patch set 3 V +2 CR +2 03/21/23, 20:46

  12. Benni Mack merged patch set 4 03/21/23, 20:47