Review main Merged

78190[FEATURE] Allow overriding button text for TCA type=file

Benni Mack CR +2 V +2 Normal +56 −6 updated 03/22/23, 19:21

Commit message

With TCA, it is possible for type=file to change
the label to a different label depending on the field.

This is useful if you want to change the label
to "Choose poster image", if e.g. the selection
of file extensions is changed.

This is done via
* [config][appearance][createNewRelationLinkTitle]

Now, the other two buttons can also be changed:
* [config][appearance][uploadFilesLinkTitle] (defaults to "Select & upload files)
* [config][appearance][addMediaLinkTitle] (defaults to "Add media by URL")

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 03/20/23, 22:05

  2. core-ci voted on patch set 1 V +1 03/20/23, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39282

  3. Benni Mack uploaded patch set 2 V +1 03/22/23, 15:23

  4. Nikita Hovratov voted on patch set 2 CR +1 03/22/23, 15:31

  5. Nikita Hovratov voted on patch set 2 V +1 03/22/23, 15:35

  6. core-ci voted on patch set 2 V +1 03/22/23, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39392

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 03/22/23, 16:54

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/22/23, 19:21

  9. Benni Mack merged patch set 3 03/22/23, 19:21