78191[TASK] Upgrade enshrined/svg-sanitize to ^0.16
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1420
-
J. Peter M. Schuler uploaded patch set 1 03/20/23, 22:18
-
J. Peter M. Schuler updated the commit message in patch set 2 03/20/23, 22:19
-
J. Peter M. Schuler updated the commit message in patch set 3 03/20/23, 22:21
-
core-ci voted on patch set 1 V -1 03/20/23, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39283
-
core-ci voted on patch set 2 V -1 03/20/23, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39284
-
J. Peter M. Schuler uploaded patch set 4 03/20/23, 22:40
-
core-ci voted on patch set 3 V -1 03/20/23, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39286
-
J. Peter M. Schuler uploaded patch set 5 03/20/23, 22:56
-
core-ci voted on patch set 4 V -1 03/20/23, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39287
-
core-ci voted on patch set 5 V +1 03/20/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39288
-
Oliver Hader commented on patch set 5 CR -2 03/21/23, 05:58
Currently it looks like that there was no XSS vulnerability in version 0.15.4 of this library. I contacted the author of this library yesterday already. -
Oliver Hader commented on patch set 5 03/21/23, 06:03
The corresponding change for v0.16.0 is available at https://github.com/darylldoyle/svg-sanitizer/commit/cce18bc237c05c6e093e9672db7926788da9b322 Two new test files were provided at: https://github.com/darylldoyle/svg-sanitizer/blob/cce18bc237c05c6e093e9672db7926788da9b322/tests/data/cdataTwoTest.svg?short_path=025a153 https://github.com/darylldoyle/svg-sanitizer/blob/cce18bc237c05c6e093e9672db7926788da9b322/tests/data/formDataTest.svg?short_path=b4118f0 Passing the content of these files through v0.15.4 of the library did not reveal any attack vector, contents of the CDATA section are correctly encoded and could not be exploited in a browser context. Can you confirm, that you got similar results? -
Oliver Hader commented on patch set 5 03/21/23, 06:54
→ demo using v0.15.4 of the lib at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78193 → please check the results there and provide feedback whether you (or anybody else of the community) was able to reproduce the vulnerability. thx! -
J. Peter M. Schuler commented on patch set 5 03/23/23, 00:12
Reply
AckReply
I firmly believe your assessment. Sounds reasonable and plausible. My change request didn't originate in own investigations, but rather just was a formal response to how to incorporate the new version.Reply
Per your analysis I rephrased this change and removed the emphasis on vulnerability, or should this rather be closed instead altogether because why bother? -
J. Peter M. Schuler updated the commit message in patch set 6
V +103/23/23, 00:12Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
core-ci voted on patch set 6 V +1 03/23/23, 00:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39429
-
Stefan Bürk commented on patch set 6 03/23/23, 00:59
Reply Unresolved
I guess we should wait until a new version is released which is free in tools and scanners or something like that. And than be raised. But up to @olly to decide on here. -
Oliver Hader commented on patch set 6 CR -2 03/23/23, 19:17
Unresolved
The corresponding CVE now has been rejected. References: * https://github.com/CVEProject/cvelist/pull/8836 * https://github.com/github/advisory-database/pull/1806 * https://github.com/darylldoyle/svg-sanitizer/issues/88 I also created a pull-request that is reverting most of the changes in v0.16.0 of the lib (basically since it's not necessary to introduce another dependency with HtmlPurifier): * https://github.com/darylldoyle/svg-sanitizer/pull/89 -
Benni Mack updated the commit message in patch set 7
V +105/03/23, 09:39Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Oliver Hader abandoned the change 05/03/23, 09:41
Not required, introducing html-purifier is also not required (and is a side effect of svg-sanitizer v0.16.0)