Review main Merged

78192[BUGFIX] Use Locale dependencies in Extbase LocalizationUtiltiy

Benni Mack CR +2 V +2 Normal +39 −12 updated 03/21/23, 17:36

Commit message

Extbase uses the $alternativeLanguageKeys,
which previously omitted the actual language
chain for XLF files, because it did not
use the Locales->createLocale() method,
but instead just used new Locale().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 79

  1. Benni Mack uploaded patch set 1 03/20/23, 23:27

  2. core-ci voted on patch set 1 V -1 03/21/23, 00:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39289

  3. Benni Mack uploaded patch set 2 V -1 03/21/23, 09:10

  4. core-ci voted on patch set 2 V +1 03/21/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39303

  5. Stefan Bürk voted on patch set 2 CR +1 03/21/23, 11:24

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 03/21/23, 15:48

  7. Stefan Bürk voted on patch set 2 V +1 03/21/23, 17:35

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 03/21/23, 17:35

  9. Stefan Bürk merged patch set 3 03/21/23, 17:36