Review main Abandoned

78193[TASK] Incorporate only tests of enshrined/svg-sanitize:v0.16.0

Oliver Hader CR 0 V 0 Easy +41 −0 updated 04/01/23, 09:40

Commit message

It looks like the security release enshrined/svg-sanitize:v0.16.0
did not fix a real vulnerability and was a false-positive:

* https://github.com/darylldoyle/svg-sanitizer/security/advisories/GHSA-xrqq-wqh4-5hg2
* https://nvd.nist.gov/vuln/detail/CVE-2023-28426
* https://github.com/darylldoyle/svg-sanitizer/commit/cce18bc237c05c6e093e9672db7926788da9b322

Processing the two new added test files with the previous version
v0.15.4 of that package did not reveal any valid attack vector - all
entities are correctly encoded and would not have led to an exploit
in a browser context. This change in the TYPO3 context aims to
demonstrate that there is no vulnerability.

Once it is verified that there was no vulnerability we'd continue
to initiate a "REJECT" process to the mentioned CVE at cve.mitre.org
(https://cve.mitre.org/cve/list_rules_and_guidance/correcting_counting_issues.html).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 46

  1. Oliver Hader uploaded patch set 1 03/21/23, 06:47

  2. Oliver Hader commented on patch set 1 03/21/23, 06:51

    formDataTest.svg:3 Unresolved

    The `<form>` inside the `<svg>` does not look nice (and is invalid), but * that's unrelated to the mentioned CDATA topic of the advisory, and * it's not executed inside the SVG context (no form rendered)

    formDataTest.svg:7 Unresolved

    The actual previous CDATA section seems to be encoded correctly.
  3. core-ci voted on patch set 1 V +1 03/21/23, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39296

  4. Markus Klein updated the commit message in patch set 2 V +1 03/21/23, 07:50

  5. core-ci voted on patch set 2 V +1 03/21/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39297

  6. Oliver Hader abandoned the change 04/01/23, 09:40

    CVE was rejected