Review main Abandoned

78194[TASK] Deprecate EXT:scheduler group description

Jochen Roth CR 0 V 0 Easy +25 −0 updated 03/27/23, 16:26

Commit message

The group description is currently not displayed
anywhere in the backend.
Therefore, the field is deprecated.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1114

  1. Jochen Roth uploaded patch set 1 03/21/23, 10:04

  2. core-ci voted on patch set 1 V +1 03/21/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39309

  3. Jochen Roth rebased onto patch set 2 V +1 03/21/23, 10:19

  4. core-ci voted on patch set 2 V +1 03/21/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39312

  5. Markus Klein updated the commit message in patch set 3 V +1 03/21/23, 10:59

  6. Markus Klein commented on patch set 3 V +1 CR +1 03/21/23, 11:00

    should be merged after #99874
  7. core-ci voted on patch set 3 V +1 03/21/23, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39317

  8. Benni Mack commented on patch set 3 CR -1 03/21/23, 11:23

    I suggest we allow to a) show the description field in the same header bar as well b) edit the description field via a "Edit Task Group" button (Form Engine) instead of the deprecation. I'm all in favor of moving more scheduler code into TCA-like style (working on that as well)
  9. Christian Kuhn commented on patch set 3 03/21/23, 13:29

    Reply Unresolved

    We removed the "edit task groups via formengine" thingie in https://review.typo3.org/c/Packages/TYPO3.CMS/+/77781 on purpose: Editing groups via FormEngine for instances allows deleting them as well, which should not be allowed if a group has attached tasks. I think it's ok to remove / deprecate the description field: It's most likely *very rarely* used anyways (and was never shown in the scheduler module) and it's most likely sufficient to have proper titles for groups, which can now be edited within the scheduler module. Apart from that, I would strongly welcome a patch that removes scheduler group record display on pid 0 altogether: Group are then made a record that can and should *only* be edited via scheduler module. These two things were at least the "plan" Jochen and me had on this. As such, I'd encourage to adapt this patch to *also* hide the group table from pid 0 (via default pagets or is there a better way?), and add that info to the rest file.
  10. Georg Ringer commented on patch set 3 V -1 03/21/23, 13:56

    instead of deprecating it, please show the field instead
  11. Christian Kuhn commented on patch set 3 03/21/23, 15:12

    Reply

    just to understand this: what's your use case? is there so much information admins want to add to a task-group that can not be reflected in the title? do you actively use the description field on task groups in projects already?
  12. Georg Ringer commented on patch set 3 03/21/23, 22:35

    Reply

    i sometimes got quite a few lines and hacving a description helps, don't just throw things away you personally don't use
  13. Christian Kuhn commented on patch set 3 03/22/23, 12:32

    Reply

    Thanks Georg. That's why I asked for your use case: To not throw away things people actively use ... I'll talk to Jochen to see if we can render the group description field and make it editable in the scheduler module as well. With this, we can disable listing of group records on pid 0 list module to prevent admins from creating broken group<->task state.
  14. Jochen Roth abandoned the change 03/27/23, 16:26

    We agreed upon not deprecating the group description field. We aim to make it editable in the scheduler module.