Review main Merged

78195[TASK] Deprecate two TypoScript related exceptions

Christian Kuhn CR +2 V +2 Normal +66 −12 updated 03/21/23, 11:38

Commit message

MissingTsfeException: This one is useless, we can
simply return false in the expression function
instead of throwing the exception.

InvalidTypoScriptConditionException: This was rendered
unused with the refactoring of the condition matcher
and expression language TypoScript implementation in
patch #100047.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/21/23, 10:35

  2. core-ci voted on patch set 1 V +1 03/21/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39313

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/21/23, 11:21

  4. Oliver Klee voted on patch set 1 V +1 CR +1 03/21/23, 11:37

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 03/21/23, 11:38

  6. Stefan Bürk merged patch set 2 03/21/23, 11:38