78197[TASK] Separate concerns in EXT:scheduler
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 17
- Build/phpstan/phpstan-baseline.neon+2 −12
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-100247-VariousInterconnectedMethodsInEXTscheduler.rstnew+78 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+84 −0
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+2 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+1 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+12 −18
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+45 −36
- typo3/sysext/scheduler/Classes/CronCommand/CronCommand.php+2 −2
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.phpnew+454 −0
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+3 −13
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+43 −137
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php+3 −1
- typo3/sysext/scheduler/Classes/Validation/Validator/TaskValidator.phpnew+42 −0
- typo3/sysext/scheduler/Classes/Scheduler.php+51 −173
- typo3/sysext/scheduler/Configuration/Services.yaml+3 −0
- typo3/sysext/scheduler/Tests/Unit/Task/ExecuteSchedulableCommandAdditionalFieldProviderTest.php+4 −0
- typo3/sysext/scheduler/Tests/Unit/Validation/Validator/TaskValidatorTest.phpnew+75 −0
Review log 2134
Show 59 earlier messages
-
Benni Mack uploaded patch set 1 03/21/23, 12:12
-
core-ci voted on patch set 1 V -1 03/21/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39320
-
Benni Mack uploaded patch set 2
V -103/21/23, 21:17 -
core-ci voted on patch set 2 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39348
-
Benni Mack uploaded patch set 3
V -103/21/23, 21:43 -
Benni Mack uploaded patch set 4 03/21/23, 21:49
-
core-ci voted on patch set 3 V -1 03/21/23, 22:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39353
-
core-ci voted on patch set 4 V -1 03/21/23, 22:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39354
-
Benni Mack uploaded patch set 5
V -103/21/23, 23:00
-
Benni Mack uploaded patch set 6 03/21/23, 23:16
-
core-ci voted on patch set 5 V -1 03/21/23, 23:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39356
-
core-ci voted on patch set 6 V -1 03/22/23, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39357
-
Benni Mack uploaded patch set 7
V -103/22/23, 10:54 -
core-ci voted on patch set 7 V -1 03/22/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39372
-
Benni Mack uploaded patch set 8
V -103/22/23, 11:22 -
core-ci voted on patch set 8 V +1 03/22/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39376
-
Jochen Roth voted on patch set 8 V +1 CR +1 03/22/23, 11:55
-
Jochen Roth uploaded patch set 9 03/22/23, 12:23
Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 9 V +1 03/22/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39380
-
Christian Kuhn commented on patch set 9 CR -1 03/22/23, 12:59
on it. -
Christian Kuhn uploaded patch set 10
CR +1V +103/22/23, 14:24 -
core-ci voted on patch set 10 V +1 03/22/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39387
-
Christian Kuhn voted on patch set 10 V +1 CR +1 03/22/23, 14:33
-
Christian Kuhn uploaded patch set 11
CR +1V +103/22/23, 14:38 -
Christian Kuhn voted on patch set 11 V +1 CR +1 03/22/23, 14:39
-
core-ci voted on patch set 11 V +1 03/22/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39388
-
Nikita Hovratov uploaded patch set 12
CR +1V +103/22/23, 15:18 -
Nikita Hovratov uploaded patch set 13 03/22/23, 15:26
-
core-ci voted on patch set 12 V +1 03/22/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39390
-
core-ci voted on patch set 13 V +1 03/22/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39393
-
Christian Kuhn voted on patch set 13 V +1 CR +1 03/22/23, 15:43
-
Nikita Hovratov voted on patch set 13 V +1 CR +1 03/22/23, 15:47
-
Nikita Hovratov voted on patch set 13 V +2 CR +2 03/22/23, 16:00
-
Nikita Hovratov merged patch set 14 03/22/23, 16:00