Review main Merged

78197[TASK] Separate concerns in EXT:scheduler

Benni Mack CR +2 V +2 Expert +904 −393 updated 03/22/23, 16:00

Commit message

This change finally cleans up logic within
the scheduler extension, namely to separate
concerns regarding reading from and writing to
the database.

All of these methods are moved to a Repository
class in order to handle database access into
one class, and to untangle the tight coupling
between the Scheduler class and the Task class.

In addition, the AbstractTask will become
a lot smaller, as it only deals with the actual
execution of the code in the future.

A new TaskValidator is added to validate if a
task can be executed.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 2134

Show 59 earlier messages
  1. Benni Mack uploaded patch set 1 03/21/23, 12:12

  2. core-ci voted on patch set 1 V -1 03/21/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39320

  3. Benni Mack uploaded patch set 2 V -1 03/21/23, 21:17

  4. core-ci voted on patch set 2 V -1 03/21/23, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39348

  5. Benni Mack uploaded patch set 3 V -1 03/21/23, 21:43

  6. Benni Mack uploaded patch set 4 03/21/23, 21:49

  7. core-ci voted on patch set 3 V -1 03/21/23, 22:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39353

  8. core-ci voted on patch set 4 V -1 03/21/23, 22:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39354

  9. Benni Mack uploaded patch set 5 V -1 03/21/23, 23:00

  1. Benni Mack uploaded patch set 6 03/21/23, 23:16

  2. core-ci voted on patch set 5 V -1 03/21/23, 23:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39356

  3. core-ci voted on patch set 6 V -1 03/22/23, 00:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39357

  4. Benni Mack uploaded patch set 7 V -1 03/22/23, 10:54

  5. core-ci voted on patch set 7 V -1 03/22/23, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39372

  6. Benni Mack uploaded patch set 8 V -1 03/22/23, 11:22

  7. core-ci voted on patch set 8 V +1 03/22/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39376

  8. Jochen Roth voted on patch set 8 V +1 CR +1 03/22/23, 11:55

  9. Jochen Roth uploaded patch set 9 03/22/23, 12:23

    Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE")
  10. core-ci voted on patch set 9 V +1 03/22/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39380

  11. Christian Kuhn commented on patch set 9 CR -1 03/22/23, 12:59

    on it.
  12. Christian Kuhn uploaded patch set 10 CR +1 V +1 03/22/23, 14:24

  13. core-ci voted on patch set 10 V +1 03/22/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39387

  14. Christian Kuhn voted on patch set 10 V +1 CR +1 03/22/23, 14:33

  15. Christian Kuhn uploaded patch set 11 CR +1 V +1 03/22/23, 14:38

  16. Christian Kuhn voted on patch set 11 V +1 CR +1 03/22/23, 14:39

  17. core-ci voted on patch set 11 V +1 03/22/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39388

  18. Nikita Hovratov uploaded patch set 12 CR +1 V +1 03/22/23, 15:18

  19. Nikita Hovratov uploaded patch set 13 03/22/23, 15:26

  20. core-ci voted on patch set 12 V +1 03/22/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39390

  21. core-ci voted on patch set 13 V +1 03/22/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39393

  22. Christian Kuhn voted on patch set 13 V +1 CR +1 03/22/23, 15:43

  23. Nikita Hovratov voted on patch set 13 V +1 CR +1 03/22/23, 15:47

  24. Nikita Hovratov voted on patch set 13 V +2 CR +2 03/22/23, 16:00

  25. Nikita Hovratov merged patch set 14 03/22/23, 16:00