Review main Merged

78200[BUGFIX] Prevent including tsconfig absolute @import twice

Nikita Hovratov CR +2 V +2 Easy +43 −4 updated 03/27/23, 11:56

Commit message

Due to a missing file suffix check, @import for tsconfig was included
twice, while it was looping through the possible ".typoscript" an
".tsconfig" file suffixes. This is now fixed by making sure that the
absolute file name ends with the current file suffix.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1014

  1. Nikita Hovratov uploaded patch set 1 03/21/23, 17:42

  2. Oliver Klee updated the commit message in patch set 2 03/21/23, 17:45

  3. core-ci voted on patch set 1 V +1 03/21/23, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39331

  4. core-ci voted on patch set 2 V +1 03/21/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39332

  5. Christian Kuhn commented on patch set 2 CR -1 03/22/23, 11:59

    will review. please give me some time.
  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 03/27/23, 11:34

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 03/27/23, 11:35

  8. core-ci voted on patch set 3 V +1 03/27/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39686

  9. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 03/27/23, 11:46

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 03/27/23, 11:46

  11. core-ci voted on patch set 4 V +1 03/27/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39691

  12. Benni Mack voted on patch set 4 V +1 CR +1 03/27/23, 11:54

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 03/27/23, 11:55

  14. Christian Kuhn merged patch set 5 03/27/23, 11:56