78201[TASK] Replace withConsecutive() call in ext:adminpanel test
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1924
-
Torben Hansen uploaded patch set 1 03/21/23, 17:55
-
core-ci voted on patch set 1 V +1 03/21/23, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39333
-
Oliver Klee commented on patch set 1 03/21/23, 21:18
-
Torben Hansen uploaded patch set 2
V +103/22/23, 07:06 -
Torben Hansen commented on patch set 1 03/22/23, 07:06
PreviewModuleTest.php:96ReplyAgree, done. -
core-ci voted on patch set 2 V +1 03/22/23, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39365
-
Oliver Klee voted on patch set 2 V +1 CR +1 03/22/23, 09:17
-
Nikita Hovratov uploaded patch set 3
CR +1V +103/22/23, 10:47 -
Nikita Hovratov uploaded patch set 4 03/22/23, 10:47
-
Nikita Hovratov commented on patch set 4 03/22/23, 10:54
PreviewModuleTest.php:96Hey, I found this pattern on GitHub while searching for "withConsecutive" replacements. It rarely makes sense to check for the exact order of execution, but to make sure expected arguments are provided. This also removes the duplicated "visibility" argument. -
core-ci voted on patch set 4 V -1 03/22/23, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39371
-
Nikita Hovratov uploaded patch set 5
V -103/22/23, 11:01 -
core-ci voted on patch set 5 V +1 03/22/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39373
-
Oliver Klee voted on patch set 5 V +1 CR +1 03/22/23, 11:22
-
Oliver Klee voted on patch set 5 CR 0 03/22/23, 11:22
-
Oliver Klee commented on patch set 5 03/22/23, 11:23
PreviewModuleTest.php:101This won't fail though if one or more of the calls is missing, of if all calls use the same. Or am I missing something here? -
Christian Kuhn updated the commit message in patch set 6
V +103/22/23, 11:26 -
core-ci voted on patch set 6 V +1 03/22/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39377
-
Nikita Hovratov commented on patch set 6 03/22/23, 12:05
PreviewModuleTest.php:101ReplyThanks for raising this point, however: 1. This was the case even before this change, as we have `$context->expects(self::any())` 2. IMO this is not good testing anyway, as we expect to know the internal processes. 3. I'd say for the sake of replacing `withConsecutive` this is fine and we can maybe convert this test to a functional and make assertions around the `$context` object. -
Christian Kuhn commented on patch set 6 03/22/23, 12:45
PreviewModuleTest.php:101ReplyYes. A functional test wouldn't be bad. There are various options to do this, one possible solution: An extension that registers a "late" middleware that gets the context injected, to then check the values, and throw a "everything ok" exception if all is fine. the test then creates a FE sub request and excepts the exception. Shouldn't be too hard. Anyone wants to step in? However, for now, since this patch is about getting rid of withConsecutive(), i'd be fine with the patch as such as well. -
Christian Kuhn voted on patch set 6 V +1 CR +1 03/22/23, 13:21
-
Nikita Hovratov voted on patch set 6 V +2 CR +2 03/22/23, 13:26
-
Nikita Hovratov merged patch set 7 03/22/23, 13:27
-
Oliver Klee commented on patch set 7 03/22/23, 13:44
PreviewModuleTest.php:101ReplyAck. Thanks everbody!
PreviewModuleTest.php:96