Review main Merged

78205[BUGFIX] Prevent TypeError in CreateRecordReactionTable

Oli Bartsch CR +2 V +2 Easy +5 −3 updated 03/21/23, 20:45

Commit message

The `items` array in an itemsProcFunc does no
longer contain item arrays but SelectItem objects.
Therefore, the corresponding type hint is changed
in CreateRecordReactionTable and the code usages
are adjusted to prevent a TypeError.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 03/21/23, 20:24

  2. Frank Nägler voted on patch set 1 V +1 CR +1 03/21/23, 20:28

  3. core-ci voted on patch set 1 V +1 03/21/23, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39344

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/21/23, 20:45

  5. Benni Mack merged patch set 2 03/21/23, 20:45