Review main Merged

78210[BUGFIX] Properly soft-delete scheduler task groups

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 04/15/23, 16:59

Commit message

Use update() over delete() to set hidden
field to 1 to soft-delete instead of
completely removing the row from DB

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1011

  1. Christian Kuhn uploaded patch set 1 03/22/23, 13:10

  2. core-ci voted on patch set 1 V +1 03/22/23, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39382

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/22/23, 13:28

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/22/23, 13:31

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 03/22/23, 13:31

  6. Nikita Hovratov merged patch set 2 03/22/23, 13:31

  7. Markus Klein commented on patch set 2 03/22/23, 13:48

    How do I recover a soft-deleted group if it is hidden on pid 0 then?
  8. Nikita Hovratov commented on patch set 2 03/22/23, 15:46

    Reply

    with ext:recycler, or what do you mean?
  9. Markus Klein commented on patch set 2 03/22/23, 16:20

    Reply

    If the table is hidden in TCA, does ext:recycler show the records then?
  10. Nikita Hovratov commented on patch set 2 03/22/23, 16:43

    Reply

    I don't know, but task_group can be recovered with recycler on root level. Besides, it is set as `adminOnly` so editors can't use it anyway.
  11. Markus Klein commented on patch set 2 03/23/23, 07:48

    Reply

    Ah, I now see that the table is not yet hidden. This did not go in with the other patch. So, all good.