Review main Merged

78213[TASK] Separate MM_match_fields from MM_insert_fields handling

Christian Kuhn CR +2 V +2 Easy +6 −10 updated 03/22/23, 16:36

Commit message

RelationHandler property $this->MM_insert_fields state
falls back to MM_match_fields in start(). This is ugly
and can be easily separated by adapting the usage
in writeMM() a bit. This avoids magic and reduces
unexpected side effects.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 03/22/23, 15:26

  2. core-ci voted on patch set 1 V +1 03/22/23, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39394

  3. Christian Kuhn uploaded patch set 2 V +1 03/22/23, 15:42

  4. Christian Kuhn updated the commit message in patch set 3 03/22/23, 15:44

  5. core-ci voted on patch set 2 V +1 03/22/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39396

  6. core-ci voted on patch set 3 V +1 03/22/23, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39397

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 03/22/23, 16:07

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 03/22/23, 16:36

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 03/22/23, 16:36

  10. Christian Kuhn merged patch set 4 03/22/23, 16:36