Review main Merged

78216[TASK] Raise codeception to unlock phpunit:^10

Christian Kuhn CR +2 V +2 Normal +88 −83 updated 03/22/23, 19:21

Commit message

> composer req --dev \
    codeception/codeception:^5.0.10 \
    codeception/lib-asserts:^2.1.0 \
    codeception/module-cli:^2.0.1 -w

With this in place, it is possible to play
around locally with phpunit:^10 using
> composer req --dev phpunit/phpunit:^10 -w

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 711

  1. Christian Kuhn uploaded patch set 1 03/22/23, 17:09

  2. core-ci voted on patch set 1 V +1 03/22/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39404

  3. core-ci commented on patch set 1 03/22/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39405

  4. Christian Kuhn commented on patch set 1 03/22/23, 17:55

    nightly is happy with this one. i'll finalize.
  5. Christian Kuhn uploaded patch set 2 03/22/23, 18:08

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  6. Christian Kuhn updated the commit message in patch set 3 V +1 03/22/23, 18:13

  7. core-ci voted on patch set 2 V +1 03/22/23, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39407

  8. core-ci voted on patch set 3 V +1 03/22/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39408

  9. Oliver Klee voted on patch set 3 V +1 CR +1 03/22/23, 18:46

  10. Benni Mack voted on patch set 3 V +2 CR +2 03/22/23, 19:21

  11. Benni Mack merged patch set 4 03/22/23, 19:21