78219[TASK] Add test for Filelist sorting function
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 1
Review log 68
-
Tymoteusz Motylewski uploaded patch set 1 03/22/23, 21:52
-
core-ci voted on patch set 1 V -1 03/22/23, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39422
-
Tymoteusz Motylewski uploaded patch set 2
V -103/23/23, 08:47 -
core-ci voted on patch set 2 V +1 03/23/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39443
-
Benni Mack commented on patch set 2 V +1 CR +1 03/23/23, 09:54
That's great. Thank you! -
Andreas Kienast voted on patch set 2 V +2 CR +2 03/23/23, 10:08
-
Andreas Kienast merged patch set 3 03/23/23, 10:08
-
Christian Kuhn commented on patch set 3 03/23/23, 10:29
overall it looks as if this would have been better suited as functional test: that would have avoided the entire mocking party, if "simply" working with some fixture files to sort.