Review main Merged

78219[TASK] Add test for Filelist sorting function

Tymoteusz Motylewski CR +2 V +2 Normal +78 −0 updated 03/23/23, 10:29

Commit message

The change https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187
provided locale aware sorting for files.

This patch proves it by providing a test.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 68

  1. Tymoteusz Motylewski uploaded patch set 1 03/22/23, 21:52

  2. core-ci voted on patch set 1 V -1 03/22/23, 22:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39422

  3. Tymoteusz Motylewski uploaded patch set 2 V -1 03/23/23, 08:47

  4. core-ci voted on patch set 2 V +1 03/23/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39443

  5. Benni Mack commented on patch set 2 V +1 CR +1 03/23/23, 09:54

    That's great. Thank you!
  6. Andreas Kienast voted on patch set 2 V +2 CR +2 03/23/23, 10:08

  7. Andreas Kienast merged patch set 3 03/23/23, 10:08

  8. Christian Kuhn commented on patch set 3 03/23/23, 10:29

    overall it looks as if this would have been better suited as functional test: that would have avoided the entire mocking party, if "simply" working with some fixture files to sort.