Review main Merged

78222[TASK] Static data providers in Tests/Unit

Christian Kuhn CR +2 V +2 Expert +674 −674 updated 03/23/23, 10:50

Commit message

phpunit ^10 expects test data providers to be static.

Using rector rule StaticDataProviderClassMethodRector,
this bulk change adapts most of them in
typo3/sysext/*/Tests/Unit.

A couple of data providers use $this, those are left
out for now and need to be adapted with dedicated
patches since they need more refactoring.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 265

Show 245 more files

Review log 57

  1. Christian Kuhn uploaded patch set 1 03/23/23, 03:51

  2. core-ci voted on patch set 1 V +1 03/23/23, 03:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39435

  3. Christian Kuhn uploaded patch set 2 V +1 03/23/23, 10:24

  4. core-ci voted on patch set 2 V +1 03/23/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39455

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/23/23, 10:38

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 03/23/23, 10:50

  7. Stefan Bürk merged patch set 3 03/23/23, 10:50