78228[TASK] Streamline icon related web components
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/element/icon-element.ts+19 −113
- Build/Sources/TypeScript/backend/element/spinner-element.ts4+22 −53
- Build/Sources/TypeScript/backend/icons.ts2+115 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+8 −99
- typo3/sysext/backend/Resources/Public/JavaScript/element/spinner-element.js+22 −53
- typo3/sysext/backend/Resources/Public/JavaScript/icons.js+97 −1
Review log 1314
-
Benjamin Kott uploaded patch set 1 03/23/23, 10:31
-
core-ci voted on patch set 1 V +1 03/23/23, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39456
-
Benni Mack voted on patch set 1 CR +1 03/24/23, 11:43
-
Andreas Kienast voted on patch set 1 V +1 CR +1 04/06/23, 07:52
-
Markus Klein commented on patch set 1 04/07/23, 20:11
-
Markus Klein commented on patch set 1 04/07/23, 20:14
spinner-element.ts:33Replyoh I now realized the imported styles rely on it of course. it works of course, be I'm not sure if I like this architecture -
Benjamin Kott commented on patch set 1 04/07/23, 20:22
spinner-element.ts:33Replythe main problem is that we needed to change the static styles in basicly inline styleset. i would loved to have it imported otherwise, the property annotations are fine in this case. but we ran into issues with sharing constructed style sheets in multiple documents. thats something i dont like but seems to be nessesary for now. it only pops up in deeply nested web components. -
Markus Klein commented on patch set 1 V +1 CR +1 04/07/23, 20:39
spinner-element.ts:33ReplyAck -
Benni Mack voted on patch set 1 V +2 CR +2 04/09/23, 20:11
-
Benni Mack merged patch set 2 04/09/23, 20:11
-
Oliver Hader commented on patch set 2 04/10/23, 16:56
It seems like I don't see icons anymore in the backend when having CSP enabled... -
Oliver Hader commented on patch set 2 04/10/23, 17:00
icons.ts:27`css` leads to inline styles... this is/was handled automatically when using in a lit-element usiong ShadomDOM. Otherwise this fails with `unsafe-inline` for CSP directive `style-src-elem`. -
Oliver Hader commented on patch set 2 04/10/23, 17:49
→ POC: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78555 Would be great somebody™ could test it. Thx!
spinner-element.ts:33