78231[TASK] Add CSP nonce helper for inline styles in lit-element templates
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/element/table-wizard-element.ts+3 −3
- Build/Sources/TypeScript/core/lit-helper.ts+34 −1
- Build/ckeditor5.rollup.config.js+6 −0
- Build/ckeditor5.rollup.functions.js2new+24 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/table-wizard-element.js+3 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php+10 −0
- typo3/sysext/core/Resources/Public/JavaScript/lit-helper.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/ckeditor5-bundle.js+13 −15
Review log 912
-
Oliver Hader uploaded patch set 1 03/23/23, 12:46
-
Oliver Hader updated the commit message in patch set 2 03/23/23, 12:48
-
core-ci voted on patch set 1 V +1 03/23/23, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39467
-
core-ci voted on patch set 2 V +1 03/23/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39468
-
Markus Klein commented on patch set 2 03/23/23, 14:20
missing word I guess. "loaded"? -
Markus Klein commented on patch set 2 03/23/23, 14:21
ckeditor5.rollup.functions.js:22can be reduced to ```JavaScript if (insertAt === 'top' && head.firstChild) { head.insertBefore(style, head.firstChild) } else { head.appendChild(style) } ``` -
Oliver Hader uploaded patch set 3
V +103/23/23, 14:59 -
Oliver Hader commented on patch set 2 03/23/23, 14:59
Reply
Ackckeditor5.rollup.functions.js:22ReplyThat was copy&paste from https://github.com/egoist/style-inject/blob/04ca45c34f20f0aa63d3d68e668de037d24579ad/src/index.js But fine to reduce it... -
core-ci voted on patch set 3 V +1 03/23/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39478
-
Benni Mack voted on patch set 3 V +1 CR +1 03/23/23, 22:44
-
Andreas Kienast voted on patch set 3 V +2 CR +2 03/24/23, 14:26
-
Andreas Kienast merged patch set 4 03/24/23, 14:26