Review main Merged

78233[TASK] Get rid of ColumnMap::$propertyName

Alexander Schnitzler CR +2 V +2 Normal +29 −41 updated 03/23/23, 22:27

Commit message

The ColumnMap only carried the propertyName to be
queried by the DataMap (of a class) to have a key
for its internal stack of ColumnMaps.

The overall goal is to separate core (TCA columns)
logic from Extbase (entity properties) logic. A
ColumnMap should only describe the actual state of
the TCA, prepared for Extbase to read but without
enriched data from entities.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 03/23/23, 13:17

  2. core-ci voted on patch set 1 V +1 03/23/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39473

  3. Alexander Schnitzler wrote 03/23/23, 18:05

    Topic set to extbase
  4. Oliver Klee voted on patch set 1 V +1 03/23/23, 21:23

  5. Oliver Klee voted on patch set 1 CR +1 03/23/23, 21:24

  6. Benni Mack commented on patch set 1 V +2 CR +2 03/23/23, 22:27

    Thanks for the commit message with the background information!
  7. Benni Mack merged patch set 2 03/23/23, 22:27