Review main Merged

78234[BUGFIX] Cast invertStateDisplay to bool in SelectItem

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 03/24/23, 06:38

Commit message

Oftentimes bool values are provided as integer in TCA. Therefore, a cast
to bool is needed for invertStateDisplay.

Note: Error might happen in itemsProcFunc for checkbox fields.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 03/23/23, 16:31

  2. Nikita Hovratov updated the commit message in patch set 2 03/23/23, 16:33

  3. core-ci voted on patch set 1 V +1 03/23/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39484

  4. core-ci voted on patch set 2 V +1 03/23/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39485

  5. Oliver Klee voted on patch set 2 V +1 CR +1 03/23/23, 21:04

  6. Nikita Hovratov commented on patch set 2 V +2 CR +2 03/24/23, 06:38

    Merging as no-brainer.
  7. Nikita Hovratov merged patch set 3 03/24/23, 06:38