Review main Merged

78238[TASK] Re-add last-changed information to workspace module

Benni Mack CR +2 V +2 Easy +8 −3 updated 03/24/23, 13:37

Commit message

Due to the removal of ExtJS in TYPO3 v8,
the "last changed" column in the workspaces
administration module was removed.

It is now added back to the view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 910

  1. Benni Mack uploaded patch set 1 03/23/23, 23:28

  2. core-ci voted on patch set 1 V +1 03/23/23, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39506

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/24/23, 12:06

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/24/23, 12:12

  5. Benni Mack commented on patch set 1 03/24/23, 12:52

    Thank you for the reviews.
  6. Benni Mack voted on patch set 1 V +2 CR +2 03/24/23, 12:52

  7. Benni Mack merged patch set 2 03/24/23, 12:52

  8. Oli Bartsch commented on patch set 2 03/24/23, 12:54

    locallang.xlf:152

    shouldn't this be "changed"?
  9. Thomas Hohn commented on patch set 2 03/24/23, 13:04

    locallang.xlf:152 Reply

    I can due a follow up and fix it 😊
  10. Benni Mack commented on patch set 2 03/24/23, 13:37

    locallang.xlf:152 Reply

    I previously thought about "Last updated" but it's also when it was added (thus "change"). I don't mind / care that much. Could also be "Last changed on"