Review main Merged

78241[BUGFIX] Fix PHP 8 warning in AbstractXmlSitemapDataProvider

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 03/26/23, 20:04

Commit message

Added a null coalescing operator around the access $item['lastMod'].

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Torben Hansen +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Thomas Hohn uploaded patch set 1 03/24/23, 12:10

  2. core-ci voted on patch set 1 V +1 03/24/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39541

  3. Nikita Hovratov commented on patch set 1 V +1 CR +1 03/24/23, 14:35

    Fix is ok, but origin of the missing key seems to be a custom XML Data Provider, as Core implementations always set this key.
  4. Guido Schmechel voted on patch set 1 CR +1 03/24/23, 14:41

  5. Torben Hansen voted on patch set 1 CR +1 03/24/23, 14:47

  6. Oliver Klee voted on patch set 1 CR +1 03/24/23, 22:15

  7. Stefan Bürk voted on patch set 1 V +2 CR +2 03/26/23, 20:04

  8. Stefan Bürk merged patch set 2 03/26/23, 20:04