Review main Merged

78242[DOCS] Improve asset ViewHelper description

Sybille Peters CR +2 V +2 Easy +21 −2 updated 03/24/23, 13:51

Commit message

The class name is removed since it is not customary for ViewHelpers and
can easily be derived from the ViewHelper name.

A description is added. In particular, the TYPO3 AssetCollector is
mentioned.

More details are added after the example (so the developer can still
easily see the example in a preview of the IDE).

Also, the specific attributes for this element are mentioned because
the automatically generated ViewHelper reference lists all attributes
in alphabetical order and quite a few make no sense for the asset
ViewHelpers.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Sybille Peters uploaded patch set 1 03/24/23, 12:25

  2. Sybille Peters uploaded patch set 2 03/24/23, 12:27

  3. core-ci voted on patch set 1 V +1 03/24/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39542

  4. core-ci voted on patch set 2 V +1 03/24/23, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39543

  5. Nikita Hovratov uploaded patch set 3 V +1 03/24/23, 13:36

  6. Nikita Hovratov voted on patch set 3 V +1 CR +1 03/24/23, 13:36

  7. Benni Mack voted on patch set 3 V +1 CR +1 03/24/23, 13:43

  8. core-ci voted on patch set 3 V +1 03/24/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39551

  9. Nikita Hovratov voted on patch set 3 V +2 CR +2 03/24/23, 13:51

  10. Nikita Hovratov merged patch set 4 03/24/23, 13:51