78243[FEATURE] Add CKEditor Inspector for backend RTE forms
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-inspector.jsnew+1 −0
- Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts+5 −0
- Build/types/TYPO3/index.d.ts+1 −0
- Build/ckeditor5.rollup.config.js+40 −22
- Build/package-lock.json+10 −0
- Build/package.json+1 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100284-AddCKEditorInspectorForBackendRTEForms.rstnew+42 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+10 −0
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/ckeditor5-inspector.jsnew+2 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.js+1 −1
Review log 2537
Show 812 earlier messages
-
Andreas Nedbal uploaded patch set 1 03/24/23, 12:53
-
Andreas Nedbal uploaded patch set 2 03/24/23, 12:57
-
core-ci voted on patch set 1 V -1 03/24/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39544
-
Andreas Nedbal uploaded patch set 3 03/24/23, 13:03
-
core-ci voted on patch set 2 V +1 03/24/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39545
-
core-ci voted on patch set 3 V +1 03/24/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39548
-
Nikita Hovratov uploaded patch set 4
V +103/24/23, 13:29 -
Nikita Hovratov voted on patch set 4 V +1 03/24/23, 13:31
-
Bastien Lutz voted on patch set 4 V +1 03/24/23, 13:38
-
core-ci voted on patch set 4 V +1 03/24/23, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39549
-
Benni Mack commented on patch set 4 03/24/23, 13:41
We could enable the inspector without an option in the RTE by just having: * TYPO3_CONTEXT=Development * and BE[debug]=1 wdyt? -
Andreas Nedbal commented on patch set 4 03/24/23, 13:55
Reply
My initial thought was that it made sense to place an explicit debug option in the CKEditor configuration as it is directly related (and then also independent from other debug options). But I guess it also could be enabled through the Development context and BE[debug]
-
Andreas Nedbal uploaded patch set 5
V +103/24/23, 16:47 -
Andreas Nedbal commented on patch set 5 03/24/23, 16:49
Reply
Done By default, the Inspector is now enabled with BE[debug]=1 and Development context. I left in the CKEditor configuration so people can still use it to explicitly enable/disable it e.g. in other environments. -
core-ci voted on patch set 5 V +1 03/24/23, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39578
-
Andreas Nedbal uploaded patch set 6
V +103/24/23, 17:48 -
Chris Müller commented on patch set 6 03/24/23, 18:15
Reply
This change should also be reflected in the feature rst. -
Andreas Nedbal uploaded patch set 7 03/24/23, 18:18
-
core-ci voted on patch set 6 V -1 03/24/23, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39580
-
Andreas Nedbal commented on patch set 7 03/24/23, 18:20
Reply
After a discussion with Benni I also adjusted this to be a task instead, rewrote the commit message and the feature RST because it is now more about the Inspector itself rather than just the configuration option. -
Andreas Nedbal uploaded patch set 8 03/24/23, 18:26
-
core-ci voted on patch set 7 V -1 03/24/23, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39581
-
Andreas Nedbal uploaded patch set 9 03/24/23, 18:33
-
core-ci voted on patch set 8 V -1 03/24/23, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39584
-
core-ci voted on patch set 9 V +1 03/24/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39585
-
Andreas Kienast updated the commit message in patch set 10
V +103/24/23, 19:01 -
core-ci voted on patch set 10 V +1 03/24/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39586
-
Stefan Bürk commented on patch set 11
V +103/24/23, 22:43Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 03/24/23, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39615
-
Andreas Kienast commented on patch set 11 CR -1 03/28/23, 05:35
on it -
Andreas Kienast uploaded patch set 12
CR -1V +103/28/23, 05:42 -
Andreas Kienast commented on patch set 12 V -1 03/28/23, 05:46
The inspector in the browser console itself works, but unfortunately, there's a CSP violation as the inspector module tries to load fonts off Google servers, ultimately breaking the inspector's toolbar. -
core-ci voted on patch set 12 V +1 03/28/23, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39746
-
Andreas Kienast commented on patch set 12 V +1 CR +1 03/28/23, 05:55
Never mind, I had a conflicting rule in my databse. -
Benni Mack voted on patch set 12 V +1 CR +1 03/28/23, 05:58
-
Andreas Kienast voted on patch set 12 V +2 CR +2 03/28/23, 06:02
-
Andreas Kienast merged patch set 13 03/28/23, 06:02