Review main Merged

78245[TASK] Streamline AssetCollector ViewHelper tests

Nikita Hovratov CR +2 V +2 Normal +40 −62 updated 03/26/23, 20:15

Commit message

Just like other ViewHelper tests, the AssetCollector ViewHelper tests
now utilize the RenderingContext and TemplateView to render a real Fluid
snippet. The AssetCollector Singleton can now also be retrieved from
the DI container.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Nikita Hovratov uploaded patch set 1 03/24/23, 14:15

  2. core-ci voted on patch set 1 V +1 03/24/23, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39557

  3. Benni Mack commented on patch set 1 V +1 CR +1 03/24/23, 21:36

    Very nice, so we can get rid of the StandaloneView here!
  4. Stefan Bürk commented on patch set 1 V +2 CR +2 03/26/23, 20:15

    Reply

    Nice, thanks Nikita.
  5. Stefan Bürk merged patch set 2 03/26/23, 20:15