Review 11.5 Merged

78251[BUGFIX] Avoid repeated e-mail content generation in FluidEmail

Markus Klein CR +2 V +2 Hard +361 −19 updated 04/24/23, 18:20

Commit message

Body content generation may be triggered by calling some getter or
indirectly when the mail is sent (via `ensureValidity`).

This changes ensures that multiple tries to generate the body are only
executed if the state of the view has actually changed.

This enables extensions to manipulate the content of an e-mail via
events without getting their changes overridden again when the mail is
sent.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 813

  1. Markus Klein uploaded patch set 1 03/24/23, 19:49

  2. Markus Klein uploaded patch set 2 03/24/23, 19:55

  3. core-ci voted on patch set 1 V -1 03/24/23, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39590

  4. core-ci voted on patch set 2 V -1 03/24/23, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39593

  5. Markus Klein uploaded patch set 3 V -1 03/24/23, 20:30

  6. core-ci voted on patch set 3 V +1 03/24/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39598

  7. Stefan Bürk commented on patch set 4 V +1 03/24/23, 22:34

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 03/24/23, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39614

  9. Stefan Bürk uploaded patch set 5 V +1 04/24/23, 13:59

  10. Markus Klein voted on patch set 5 CR +1 04/24/23, 14:01

  11. core-ci voted on patch set 5 V +1 04/24/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41170

  12. Stefan Bürk voted on patch set 5 V +2 CR +2 04/24/23, 18:20

  13. Stefan Bürk merged patch set 6 04/24/23, 18:20