78258[BUGFIX] Correct signature in ArrayUtility::isValidPath
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1420
-
Thomas Hohn uploaded patch set 1 03/26/23, 08:54
-
core-ci voted on patch set 1 V +1 03/26/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39639
-
Oliver Klee updated the commit message in patch set 2
V +103/26/23, 11:52 -
Oliver Klee updated the commit message in patch set 3 03/26/23, 11:54
-
core-ci voted on patch set 3 V +1 03/26/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39642
-
core-ci voted on patch set 2 V +1 03/26/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39641
-
Christoph Lehmann commented on patch set 3 CR +1 03/26/23, 13:30
Code looks good to me, but IMHO it's not a bug(fix), more a streamline task. (no blocker). -
Thomas Hohn updated the commit message in patch set 4
CR +1V +103/26/23, 14:22 -
core-ci voted on patch set 4 V +1 03/26/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39645
-
Alexander Opitz voted on patch set 4 V +1 CR +1 03/26/23, 16:19
-
Guido Schmechel commented on patch set 4 03/26/23, 17:28
Can we add tests for that then? If it's not noticeable yet, it makes sense to add it. -
Stefan Bürk commented on patch set 4 03/26/23, 20:10
A task stating "Fix..." is quite cumbersome. At least rephrase it a bit. Even if taken as "bugfix" it's not really helpfull. Suggest to use something like: ``` [TASK] Broaden argument type declaration for ArrayUtility::isValidPath() ``` Not looked into the code yet - can you at least state `why` the arguement `$path` should be `array|string`. And repeating "fix" in the commit message ... if you really consider to "fix" something, it should be a bugfix. -
Thomas Hohn commented on patch set 4 03/26/23, 20:29
Reply
The method getValueByPath has array|string for the $path argument - I since the "only" purpose of isValidPath is calling that function it should have the same signature. Will change it to a bugfix -
Thomas Hohn uploaded patch set 5
CR +1V +103/26/23, 20:45 -
Thomas Hohn updated the commit message in patch set 6 03/26/23, 20:47
-
core-ci voted on patch set 6 V +1 03/26/23, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39653
-
core-ci voted on patch set 5 V +1 03/26/23, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39652
-
Stefan Bürk voted on patch set 6 V +1 CR +1 03/26/23, 23:21
-
Georg Ringer voted on patch set 6 V +2 CR +2 03/27/23, 05:28
-
Georg Ringer merged patch set 7 03/27/23, 05:28