78259[FEATURE] Add PSR-14 event to enrich password validation ContextData
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php1+14 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+11 −0
- typo3/sysext/core/Classes/PasswordPolicy/Event/EnrichPasswordValidationContextDataEvent.php5new+52 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100294-AddPSR-14EventToEnrichPasswordValidationContextData.rstnew+78 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+8 −0
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php+10 −0
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+11 −0
Review log 1415
-
Torben Hansen uploaded patch set 1 03/26/23, 10:33
-
core-ci voted on patch set 1 V +1 03/26/23, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39640
-
Oliver Hader voted on patch set 1 CR +1 03/26/23, 14:36
-
Oliver Hader voted on patch set 1 V +1 03/26/23, 14:38
-
Oliver Hader commented on patch set 1 03/26/23, 14:40
-
Benni Mack commented on patch set 1 03/27/23, 07:33
EnrichPasswordValidationContextDataEvent.php:50Replydo we need this? -
Oliver Hader commented on patch set 1 03/27/23, 08:35
EnrichPasswordValidationContextDataEvent.php:50ReplyNot a requirement to have an instance here. -
Torben Hansen commented on patch set 1 03/27/23, 08:36
EnrichPasswordValidationContextDataEvent.php:50ReplyI thought about providing the instance of the object but dropped the idea, since most instances are controllers with basically not many public accessible properties. So I think it is ok to just use the classname in the event, so extension can differentiate, in which class the `ContextData` DTO has been created. -
Simon Schaufelberger voted on patch set 1 CR +1 03/27/23, 10:12
-
Benni Mack commented on patch set 1 03/27/23, 10:51
EnrichPasswordValidationContextDataEvent.php:50ReplyI would rather have a string than a class name here, just like a "Context" string with "persistence" and "user-settings" or "password-recovery". -
Benni Mack voted on patch set 1 V +1 03/27/23, 18:56
-
Georg Ringer commented on patch set 1 03/27/23, 19:05
PasswordReset.php:283Unresolvedwhy not just hand over the full row instead of a manually picked number of fields? -
Oliver Hader voted on patch set 1 CR +2 03/27/23, 19:12
-
Oliver Hader voted on patch set 1 V +2 03/27/23, 19:12
-
Oliver Hader merged patch set 2 03/27/23, 19:13
EnrichPasswordValidationContextDataEvent.php:50