Review main Merged

78261[TASK] Provide PSR-14 `RedirectWasHitEvent` as webhook message

Stefan Bürk CR +2 V +2 Normal +166 −0 updated 03/27/23, 20:10

Commit message

With #99629 outgoing webhooks has been implemented. This also
provide a simple way to create custom webhook messages for
any PSR-14 event. Therefore, the `RedirectWasHit` event can
be used to provide an additional webhook type and showcase
the needed steps to add this for a core PSR-14 event.

This change provides a webhook message for the already
existing PSR-14 `RedirectWasHitEvent` of `ext:redirects`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 913

  1. Stefan Bürk uploaded patch set 1 03/26/23, 22:54

  2. Stefan Bürk uploaded patch set 2 03/26/23, 22:55

  3. core-ci voted on patch set 1 V -1 03/26/23, 23:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39654

  4. core-ci voted on patch set 2 V +1 03/26/23, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39655

  5. Stefan Bürk uploaded patch set 3 V +1 03/26/23, 23:04

  6. core-ci voted on patch set 3 V +1 03/26/23, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39656

  7. Benni Mack commented on patch set 3 03/27/23, 07:40

    RedirectWasHitMessage.php:37

    what's that?
  8. Stefan Bürk commented on patch set 4 V +1 03/27/23, 07:53

    Published edit on patch set 3.
  9. Stefan Bürk commented on patch set 4 03/27/23, 07:53

    RedirectWasHitMessage.php:37 Reply

    breakpoint left-over. removed.
  10. core-ci voted on patch set 4 V +1 03/27/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39668

  11. Benni Mack commented on patch set 4 V +1 CR +1 03/27/23, 08:05

    very nice one!
  12. Andreas Kienast voted on patch set 4 V +2 CR +2 03/27/23, 20:10

  13. Andreas Kienast merged patch set 5 03/27/23, 20:10