Review main Merged

78263[FEATURE] Replace AbstractUserAuth hooks with PSR-14 Events

Benni Mack CR +2 V +2 Hard +390 −74 updated 03/27/23, 16:45

Commit message

Two new Events are added
* TYPO3\CMS\Core\Authentication\Event\BeforeUserLogoutEvent
* TYPO3\CMS\Core\Authentication\Event\AfterUserLoggedOutEvent
* TYPO3\CMS\Core\Authentication\Event\AfterUserLoggedInEvent

They should be used instead of the hooks:
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['logoff_pre_processing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['logoff_post_processing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauthgroup.php']['backendUserLogin']

as they are now deprecated.

This is an ongoing effort to remove hooks and use
a better and more flexible PSR-14-based EventListener system.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 1118

  1. Benni Mack uploaded patch set 1 03/27/23, 08:04

  2. core-ci voted on patch set 1 V -1 03/27/23, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39670

  3. Benni Mack uploaded patch set 2 V -1 03/27/23, 08:22

  4. core-ci voted on patch set 2 V +1 03/27/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39671

  5. Benni Mack uploaded patch set 3 V +1 03/27/23, 09:04

  6. core-ci voted on patch set 3 V -1 03/27/23, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39675

  7. Benni Mack commented on patch set 4 V -1 03/27/23, 10:32

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V -1 03/27/23, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39681

  9. Benni Mack uploaded patch set 5 V -1 03/27/23, 13:56

  10. core-ci voted on patch set 5 V -1 03/27/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39698

  11. Andreas Kienast uploaded patch set 6 V -1 03/27/23, 14:46

  12. core-ci voted on patch set 6 V +1 03/27/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39703

  13. Andreas Kienast commented on patch set 6 CR -1 03/27/23, 14:55

    still on it
  14. Andreas Kienast uploaded patch set 7 CR -1 V +1 03/27/23, 15:00

  15. core-ci voted on patch set 7 V +1 03/27/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39704

  16. Andreas Kienast voted on patch set 7 V +1 CR +1 03/27/23, 15:10

  17. Stefan Bürk voted on patch set 7 V +2 CR +2 03/27/23, 16:45

  18. Stefan Bürk merged patch set 8 03/27/23, 16:45