Review main Merged

78268[TASK] Use explicit types for `willReturnCallback` in EXT:backend tests

Oliver Klee CR +2 V +2 Normal +67 −59 updated 03/27/23, 18:42

Commit message

This improves both code readability as well as type safety in the tests.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Oliver Klee uploaded patch set 1 03/27/23, 12:49

  2. core-ci voted on patch set 1 V +1 03/27/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39694

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/27/23, 14:07

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 03/27/23, 18:39

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 03/27/23, 18:42

  6. Nikita Hovratov merged patch set 2 03/27/23, 18:42