Review main Merged

78272[TASK] Harden willReturnCallback calls in some extension tests

Oliver Klee CR +2 V +2 Normal +39 −27 updated 04/13/23, 12:28

Commit message

- add parameter and return type declarations
- use the same parameter names as in the mocked methods
- use first-class callables
- replace `isType()` calls with parameter type declarations

… in the `willReturnCallback` callbacks in the unit tests of these
extensions:

- fluid
- form
- frontend
- impexp
- install
- seo

This improves code readability and type safety.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 813

  1. Oliver Klee uploaded patch set 1 03/27/23, 15:11

  2. core-ci voted on patch set 1 V +1 03/27/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39705

  3. Oliver Klee rebased onto patch set 2 V +1 03/27/23, 19:49

  4. core-ci voted on patch set 2 V +1 03/27/23, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39723

  5. Oliver Klee uploaded patch set 3 V +1 04/04/23, 09:36

  6. Oliver Klee updated the commit message in patch set 4 04/04/23, 09:37

  7. core-ci voted on patch set 3 V +1 04/04/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40065

  8. core-ci voted on patch set 4 V +1 04/04/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40066

  9. Oliver Klee rebased onto patch set 5 V +1 04/13/23, 08:00

  10. core-ci voted on patch set 5 V +1 04/13/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40549

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 04/13/23, 12:25

  12. Andreas Kienast voted on patch set 5 V +2 CR +2 04/13/23, 12:27

  13. Andreas Kienast merged patch set 6 04/13/23, 12:28