Review main Merged

78274[TASK] Make ImageDimensionTest phpunit 10 ready

Christian Kuhn CR +2 V +2 Normal +103 −125 updated 03/27/23, 18:35

Commit message

* Static DP
* Avoid withConsecutive() - kinda useless in
  this case anyways
* Don't use $this in DP

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/27/23, 17:41

  2. core-ci voted on patch set 1 V +1 03/27/23, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39711

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/27/23, 18:11

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 03/27/23, 18:33

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/27/23, 18:35

  6. Christian Kuhn merged patch set 2 03/27/23, 18:35